correct a typo in a namespace loading #10354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the correct namespace is not `Symfony\Component\HttpKernel\DependencyInjection\Extension` but `Symfony\Component\DependencyInjection\Extension\Extension`. The mistake is present on all versions of the doc I checked, so I propose the correction on the oldest LTS but ie the 4.2 also have the typo. If using the typo, the code still works because `Symfony\Component\HttpKernel\DependencyInjection\Extension` extends `Symfony\Component\DependencyInjection\Extension\Extension`
javiereguiluz
added
DependencyInjection
Status: Reviewed
and removed
Status: Needs Review
labels
|
Nice fix and perfectly explained! @bruno-ds thanks for the detailed explanation ... and congrats on your first contribution to Symfony Docs! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 17, 2018
This PR was merged into the 2.8 branch. Discussion ---------- correct a typo in a namespace loading the correct namespace is not `Symfony\Component\HttpKernel\DependencyInjection\Extension` but `Symfony\Component\DependencyInjection\Extension\Extension`. The mistake is present on all versions of the doc I checked, so I propose the correction on the oldest LTS but ie the 4.2 also have the typo. If using the typo, the code still works because `Symfony\Component\HttpKernel\DependencyInjection\Extension` extends `Symfony\Component\DependencyInjection\Extension\Extension` <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- b3ca081 correct a typo in a namespace loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the correct namespace is not
Symfony\Component\HttpKernel\DependencyInjection\ExtensionbutSymfony\Component\DependencyInjection\Extension\Extension.The mistake is present on all versions of the doc I checked, so I propose the correction on the oldest LTS but ie the 4.2 also have the typo.
If using the typo, the code still works because
Symfony\Component\HttpKernel\DependencyInjection\ExtensionextendsSymfony\Component\DependencyInjection\Extension\Extension